Conversation
|
🤖 Hi @TommrraraSnow, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This pull request introduces a well-designed and modular buff engine. The separation of definitions, registry, runtime services, and storage is clean and promotes extensibility. The code is generally of high quality and includes a good set of initial tests.
🔍 General Feedback
- The core logic is sound, but the
BuffStoreis missing the implementation of stacking rules, which is a key part of buff management. - The use of SQLite for the registry is appropriate, and the schema is well-defined.
- The testing strategy is good, covering unit and integration aspects of the new engine. Expanding test coverage for edge cases would be beneficial.
| self._store.setdefault(instance.owner_id, []).append(instance) | ||
|
|
||
| def remove(self, owner_id: str, predicate: Callable[[BuffInstance], bool]) -> int: | ||
| instances = self._store.get(owner_id, []) |
There was a problem hiding this comment.
🟠 The add method in BuffStore currently appends new buff instances without considering stacking rules defined in BuffDefinition (e.g., max_stacks, stacking_rule). This could lead to incorrect behavior where buffs stack indefinitely or don't refresh as expected. The store should probably handle logic for refreshing durations, incrementing stacks, or replacing instances based on the buff's stacking rule.
| if isinstance(value, str): | ||
| value = json.loads(value) | ||
| return tuple(value or ()) | ||
|
|
There was a problem hiding this comment.
🟢 The pattern if isinstance(value, str): value = json.loads(value) is repeated in _ensure_sequence, _ensure_tuple, _ensure_mapping, and _selector_from_payload. To improve code reuse, this logic could be extracted into a utility function.
1 participant
Summary
buff_enginepackage with declarative definitions and runtime servicesTesting
uv run pytest tests/test_buff_engine.pyhttps://chatgpt.com/codex/tasks/task_e_68e3f8848598832d9ebfd27e571827b5